Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for timeout in wait_deployment_replica_ready and fail if so. #1818

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: check for timeout in wait_deployment_replica_ready and fail if so. #1818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions manager/integration/tests/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4783,6 +4783,7 @@ def finalizer():

def wait_deployment_replica_ready(apps_api, deployment_name,
desired_replica_count, namespace='default'): # NOQA
ok = False
for i in range(DEFAULT_DEPLOYMENT_TIMEOUT):
deployment = apps_api.read_namespaced_deployment(
name=deployment_name,
Expand All @@ -4791,9 +4792,11 @@ def wait_deployment_replica_ready(apps_api, deployment_name,
# deployment is none if deployment is not yet created
if deployment is not None and \
deployment.status.ready_replicas == desired_replica_count:
ok = True
break

time.sleep(DEFAULT_DEPLOYMENT_INTERVAL)
assert ok
c3y1huang marked this conversation as resolved.
Show resolved Hide resolved


def create_and_wait_deployment(apps_api, deployment_manifest):
Expand Down