Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct makefile typo and add make enter command #741

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Correct makefile typo and add make enter command #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ VERSION = $(shell ./scripts/version)
REPO = longhornio
NAME = longhorn-ui
INSTANCE = default
LONHORN_MANAGER_IP = http://localhost:9500
LONGHORN_MANAGER_IP = http://localhost:9500
PORT = 8000
IMAGE = $(REPO)/$(NAME):$(VERSION)

BASE_IMAGE = $(shell grep FROM Dockerfile | grep -vi ' AS ' | awk '{print $$2}' )

.PHONY: build push shell run start stop rm release
.PHONY: build push shell run start stop rm release enter

build:
# update base image to get latest changes
Expand All @@ -25,4 +25,7 @@ stop:
run:
docker run -d --name $(NAME)-$(INSTANCE) -p $(PORT):8000 -e LONGHORN_MANAGER_IP=$(LONGHORN_MANAGER_IP) $(REPO)/$(NAME):$(VERSION)

enter:
docker exec -it $(NAME)-$(INSTANCE) /bin/bash

default: build
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Prerequisites:

Setup:
```bash
git clone 'https://github.com/rancher/longhorn-ui'
git clone 'https://github.com/longhorn/longhorn-ui'
cd 'longhorn-ui'
npm ci
```
Expand All @@ -31,7 +31,7 @@ Compiling for distribution
npm run build
```

Build and run a docker image
Build and run a docker image, longhorn UI will listen on localhost:8000
```bash
make
make LONGHORN_MANAGER_IP=http://longhorn:9500 run
Expand Down