Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct makefile typo and add make enter command #741

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented Jun 4, 2024

What's change in this PR

  • fix makefile typo
  • add make enter command
  • update REDAM.md

Test Result

Run below commands on my Macbook

  • make build : build longhorn-ui image from Dockerfile
  • make run : run up docker container listening on localhost 8000
  • make enter : enter container shell
Screenshot 2024-06-04 at 11 08 32 AM Screenshot 2024-06-04 at 11 08 25 AM

@a110605 a110605 requested review from torchiaf and a team June 4, 2024 03:15
@a110605 a110605 self-assigned this Jun 4, 2024
@a110605 a110605 changed the title fix makefile typo and add make enter command Correct makefile typo and add make enter command Jun 4, 2024
@a110605 a110605 force-pushed the fix_make branch 6 times, most recently from 515c3ab to 1634e99 Compare June 5, 2024 07:20
Copy link

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 merged commit 02b42ff into longhorn:master Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants