-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter-by-language to study list #1344
base: develop
Are you sure you want to change the base?
Add filter-by-language to study list #1344
Conversation
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a nice add. Just the one issue to resolve.
class StudyLanguage(FormChoiceEnum): | ||
all = ("*", _("All languages")) | ||
english = ("en", _("English")) | ||
japanese = ("ja", _("Japanese")) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is great. The filter drop-down would need to have the languages of all available studies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to do that, I am unsure at this moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At present, we believe there are only ja and en studies. But did you mean you'd like to automatically populate this list by querying the available studies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. If someone were to create a Spanish study, they wouldn't be able to use this filter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okaycj is correct, if we want to create a language filter for studies (which is a great idea!), we should go ahead and build the capacity to do it for any of the other languages we support.
There are many English studies on lookit and at present only one Japanese one. We are worried that on the studies list page, the mass of English studies will be off-putting and confusing, and rarely useful. So, this commit: