-
Notifications
You must be signed in to change notification settings - Fork 476
Implement RFC, rename "class" to "extern" locked behind a debug flag - by replacing function pointers #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Me when Unit Tests fail here, but not my end. |
|
If this fails as well, I probably have to use |
|
Works, but I think the tenary operator is doing the opposite thing? This passed the Unit Tests, soo... |
|
Alright, I did static std::string getTag_DEPRECATED(lua_State* L, TypeFunctionTypeId ty);
static std::string getTag_NEW(lua_State* L, TypeFunctionTypeId ty);
// Original function is named "getTag"
using GetTagFunc = std::string (*)(lua_State*, TypeFunctionTypeId);
static GetTagFunc getTag = getTag_DEPRECATED;
TypeFunctionRuntime::TypeFunctionRuntime(NotNull<InternalErrorReporter> ice, NotNull<TypeCheckLimits> limits)
: ice(ice)
, limits(limits)
, state(nullptr, dummyStateClose)
{
if (FFlag::DebugLuauRenameClassToExtern)
{
getTag = getTag_NEW;
}
}and that worked |
|
This is not the appropriate way to flag this, the other PR is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for luau-lang/rfcs#131 incase it gets merged
This is variation 1.
Variation 2 is here: #1927
In this variation I replaced the functions. And the feature is locked behind
FFlagDebugLuauRenameClassToExtern, it's prefixed with Debug, so it doesn't get enabled by--fflags=true, which allows us to transition to get rid of every existing reference of"class".The reason why I replace functions in this variation, is because I thought that this is the optimal way, and won't add an extra instruction everytime you'd call
:is