Skip to content

Conversation

karl-police
Copy link
Contributor

Implementation for luau-lang/rfcs#131 incase it gets merged

It's like #1926, but different

@karl-police karl-police changed the title Implement RFC, rename "class" to "extern" locked behind a debug flag - variation 2 Implement RFC, rename "class" to "extern" locked behind a debug flag, tenary operator Jul 23, 2025
@aatxe
Copy link
Collaborator

aatxe commented Aug 21, 2025

This is the correct way to do it, not the other way, but it needs a rebase. The flag should not be a debug flag.

@karl-police
Copy link
Contributor Author

Hmm, without Debug at the front. I wonder if this will error out Unit Tests that use :is("class"), most likely yes

@karl-police karl-police changed the title Implement RFC, rename "class" to "extern" locked behind a debug flag, tenary operator Implement RFC, rename "class" to "extern" locked behind a flag, tenary operator Aug 21, 2025
@karl-police
Copy link
Contributor Author

I guess there are no Unit Tests.

@aatxe
Copy link
Collaborator

aatxe commented Aug 21, 2025

you should flag those tests to change to using extern when the flag is enabled

@karl-police
Copy link
Contributor Author

you should flag those tests to change to using extern when the flag is enabled

the new one?

@karl-police karl-police changed the title Implement RFC, rename "class" to "extern" locked behind a flag, tenary operator Implement RFC, rename tag "class" to "extern" locked behind a flag, tenary operator Aug 21, 2025
@aatxe
Copy link
Collaborator

aatxe commented Aug 22, 2025

not if it's new, but if there were any existing tests, you'd flag them to reflect the change

@karl-police
Copy link
Contributor Author

not if it's new, but if there were any existing tests, you'd flag them to reflect the change

It doesn't look like there were, and if there were it would have failed the build checks. But for future changes, I will look out for that. (Well, if the build fails I have to fix it regardless)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants