-
Notifications
You must be signed in to change notification settings - Fork 476
Implement RFC, rename tag "class" to "extern" locked behind a flag, tenary operator #1927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This is the correct way to do it, not the other way, but it needs a rebase. The flag should not be a debug flag. |
Hmm, without |
I guess there are no Unit Tests. |
you should flag those tests to change to using |
the new one? |
not if it's new, but if there were any existing tests, you'd flag them to reflect the change |
It doesn't look like there were, and if there were it would have failed the build checks. But for future changes, I will look out for that. (Well, if the build fails I have to fix it regardless) |
Implementation for luau-lang/rfcs#131 incase it gets merged
It's like #1926, but different