setlist and songUpdates #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he user created for now Not sure if this is what we were thinking of for the MVP or if it was going to be a free for all and users could use eachothers songs.
a user should be able to only get their created setlists. more than likely this will be more of an organization or band hierarchy kinda thing but for mvp this will work.
added song in user id 3 and some categories
faster local dev interations for when the database needs to be hard reset and starting from scratch.
The format time was from our implementation in lumastic-app, the format runtime is for computing the friendly version of the stored seconds of runtime.
this should be evaluated and removed if necessary, i believe our implementation of the library is probably covered in standard JS at this time.
was having too many issues with the form updating and what not. Proabbly have to be a controlled input?
drewlyton
requested changes
Jan 26, 2023
| @@ -10,6 +10,7 @@ | |||
| "db:deploy": "npx prisma migrate deploy", | |||
| "db:push": "npx prisma db push", | |||
| "db:reset": "rm -r prisma/data.db && npm run db:push", | |||
| "db:hard-refresh": "rm -r prisma/data.db && npm run db:push && npm run db:seed", | |||
There was a problem hiding this comment.
I'm down to just add the seed command to db:reset if you want?
app/helpers/formatTime.ts
Outdated
| @@ -0,0 +1,36 @@ | |||
| import moment from "moment"; | |||
There was a problem hiding this comment.
Moment doesn't recommend using Moment anymore so maybe we should look at other libraries that are smaller (or just use native JS dates). What are we trying to display, just a string that says like "3m" or "4m". I can't imagine Grayson and I ever really putting seconds since our estimations of time aren't that exact.
There was a problem hiding this comment.
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for review and merge after #13 is rebase and merged