-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setlist and songUpdates #14
Open
kstolte
wants to merge
16
commits into
main
Choose a base branch
from
setlist-and-songUpdates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fc5228a
fix(songs): restricting the fetching of songs to just the ones that t…
kstolte 0d85de0
feat(db): adding author for setlist
kstolte 1cef83e
fix(ap): restricting fetching of setlists to only the users created s…
kstolte 4a822e8
feat(db): adding new fields for song usage
kstolte 42d3af5
test: adding some basic working data in prisma
kstolte 4dfd633
chore(scripts): db:hard-refresh for destroying the database and reseed
kstolte c55e26a
feat(helpers): bringing over some time formatting
kstolte aa29c69
build(package.json): adding momentjs for display of local time
kstolte 2f2c8ec
removing claimedPublicDomain at this time
kstolte 76cec09
updating form for supporting new fields for song editor
kstolte e59f205
adding runtime and notes for the song viewer
kstolte b78266e
refactor: renaming the setlist func to match the song nomenclature
kstolte 70de7ab
swapping runtimes
kstolte 2e4b86a
create mock song in seed
kstolte eea5afc
formatruntime
kstolte e554228
Merge branch 'mvp' into setlist-and-songUpdates
drewlyton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import formatTime from "./formatTime"; | ||
|
||
describe("Time ago tests", () => { | ||
test("less than 1m ago", () => { | ||
expect( | ||
formatTime({ | ||
time: new Date() - 1, | ||
}) | ||
).toStrictEqual("a few seconds ago"); | ||
}); | ||
}); | ||
|
||
describe("additional format testing", () => { | ||
test("full date", () => { | ||
expect( | ||
formatTime({ | ||
time: "2020-04-06T18:19:00.000Z", | ||
fullDate: true, | ||
}) | ||
).toStrictEqual("April 6, 2020"); | ||
}); | ||
test("full date and time", () => { | ||
expect( | ||
formatTime({ | ||
time: "2020-04-06T18:19:00.000Z", | ||
fullDate: true, | ||
withTime: true, | ||
}) | ||
).toStrictEqual("April 6, 2020 2:19 PM"); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import moment from "moment"; | ||
|
||
/** | ||
* Implements Moment.js for formatting dates | ||
* https://momentjs.com/docs/#/displaying/fromnow/ | ||
* | ||
* @param {{time:Date}} param0 input parameters | ||
*/ | ||
const formatTime = ({ | ||
time = "", | ||
fullDate = false, | ||
withTime = false, | ||
ago = true, | ||
}) => { | ||
if (fullDate) { | ||
let format = "LL"; | ||
if (withTime) { | ||
format += "L"; | ||
} | ||
return moment(time).format(format); | ||
} | ||
return moment(time).fromNow(!ago); | ||
}; | ||
|
||
export default formatTime; | ||
|
||
/** | ||
* formats the runtime in seconds to US-EN format. | ||
*/ | ||
export const formatRunTime = (runtime: number) => { | ||
if (runtime < 60) return `${runtime} sec.`; | ||
let min = runtime / 60; | ||
min = ~~min; | ||
const remSec = runtime % 60; | ||
return `${min} min. ${remSec} sec.`; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ | |
"db:deploy": "npx prisma migrate deploy", | ||
"db:push": "npx prisma db push", | ||
"db:reset": "rm -r prisma/data.db && npm run db:push", | ||
"db:hard-refresh": "rm -r prisma/data.db && npm run db:push && npm run db:seed", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm down to just add the seed command to |
||
"db:seed": "npx prisma db seed", | ||
"db:studio": "npx prisma studio -p 7777 --browser none", | ||
"dev": "concurrently \"npm run dev:css\" \"remix dev\"", | ||
|
@@ -40,6 +41,7 @@ | |
"debounce": "^1.2.1", | ||
"dotenv-cli": "^6.0.0", | ||
"fuse.js": "^6.6.2", | ||
"moment": "^2.28.0", | ||
"qrcode": "^1.5.1", | ||
"qs": "^6.11.0", | ||
"react": "^18.2.0", | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moment doesn't recommend using Moment anymore so maybe we should look at other libraries that are smaller (or just use native JS dates). What are we trying to display, just a string that says like "3m" or "4m". I can't imagine Grayson and I ever really putting seconds since our estimations of time aren't that exact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://momentjs.com/docs/#/-project-status/