fix: clip hrnet scores #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbmrz
requested review from
tersekmatija,
kkeroo and
klemen1999
as code owners
github-actions
bot
added
parsers
|
Not really sure what's wrong with the pre-commit check. Running |
klemen1999
approved these changes
Oct 16, 2024
|
PR is merging to |
Yes let's merge to main from now. But we need to be even more sure that we don't introduce breaking changes now |
kkeroo
approved these changes
Oct 16, 2024
|
The changes presented here are being added to the Parsers v2 review PR #113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for the
HRNetParser. Scores with calues >1 were occurring (max. observed was 1.1) and this was causing errors later in the process.