-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clip hrnet scores #110
Conversation
Not really sure what's wrong with the pre-commit check. Running |
PR is merging to |
Yes let's merge to main from now. But we need to be even more sure that we don't introduce breaking changes now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I ran the tests locally and they went through.
The changes presented here are being added to the Parsers v2 review PR #113 |
This is a quick fix for the
HRNetParser
. Scores with calues >1 were occurring (max. observed was 1.1) and this was causing errors later in the process.