Epytext documentation. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ImageOutputParser class for image-to-image models (e.g. DnCNN3, zero-dce etc.) | ||
| where the output is modifed image (denoised, enhanced etc.). | ||
|
|
||
| @param input: Node's input. It accepts the output of the Neural Network node. |
There was a problem hiding this comment.
I guess the input and out are used for linking?
IMO output_is_bgr is better if in constructor itself?
There was a problem hiding this comment.
Left it also in the parser itself as discussed.
| Node's input. It is a linking point to which the Neural Network's output is linked. It accepts the output of the Neural Network node. | ||
| out : Node.Output | ||
| Parser sends the processed network results to this output in form of messages. It is a linking point from which the processed network results are retrieved. | ||
| nn_passthrough : Node.Input |
There was a problem hiding this comment.
Wouldn't this be connected as:
CameraNode -> NN -> Parser -> NN -> Parser?
Or are we doing this in a different manner here?
There was a problem hiding this comment.
No, it's NN->NN->Parser. The the first NN output also goes to parser. Now, I am thinking that actually both blobs can be joined into one
jkbmrz
reviewed
Jul 19, 2024
jkbmrz
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is not yet ready for merge. I pushed just two files to check if the documentation format is correct. if anything comes to your mind @tersekmatija and @jkbmrz please say.
Do you agree we proceed like this?