-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epytext documentation. #13
Conversation
"""ImageOutputParser class for image-to-image models (e.g. DnCNN3, zero-dce etc.) | ||
where the output is modifed image (denoised, enhanced etc.). | ||
|
||
@param input: Node's input. It accepts the output of the Neural Network node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the input and out are used for linking?
IMO output_is_bgr is better if in constructor itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left it also in the parser itself as discussed.
Node's input. It is a linking point to which the Neural Network's output is linked. It accepts the output of the Neural Network node. | ||
out : Node.Output | ||
Parser sends the processed network results to this output in form of messages. It is a linking point from which the processed network results are retrieved. | ||
nn_passthrough : Node.Input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be connected as:
CameraNode -> NN -> Parser -> NN -> Parser?
Or are we doing this in a different manner here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's NN->NN->Parser. The the first NN output also goes to parser. Now, I am thinking that actually both blobs can be joined into one
The PR is not yet ready for merge. I pushed just two files to check if the documentation format is correct. if anything comes to your mind @tersekmatija and @jkbmrz please say.
Do you agree we proceed like this?