Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paddle text detection parser #60

Merged
merged 15 commits into from
Sep 10, 2024
Merged

Paddle text detection parser #60

merged 15 commits into from
Sep 10, 2024

Conversation

aljazkonec1
Copy link
Contributor

Added Paddle Text detection parser. The output of PaddleOCR Text detection model is a mask of probabilites over the entire image that need to be processed to get valid bounding boxes.

@github-actions github-actions bot added the parsers Changes affecting ml.parsers label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Test Results

120 tests   120 ✅  1s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 50a237b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 9, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2208 879 40% 0% 🟢

New Files

File Coverage Status
depthai_nodes/ml/parsers/ppdet.py 31% 🟢
depthai_nodes/ml/parsers/utils/ppdet.py 10% 🟢
TOTAL 20% 🟢

Modified Files

File Coverage Status
depthai_nodes/ml/parsers/init.py 100% 🟢
depthai_nodes/ml/parsers/utils/init.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 50a237b by action🐍

Copy link
Collaborator

@kkeroo kkeroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise, just two small comments. Quick thought: Is it possible to also have ppocr recognition in this parser and then based on incoming tensor shape we run detection decoding or recognition decoding?

depthai_nodes/ml/parsers/ppocr_text_detection.py Outdated Show resolved Hide resolved
depthai_nodes/ml/parsers/ppocr_text_detection.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jkbmrz jkbmrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor syntax comments. LGTM otherwise!

depthai_nodes/ml/parsers/ppocr_text_detection.py Outdated Show resolved Hide resolved
depthai_nodes/ml/parsers/ppocr_text_detection.py Outdated Show resolved Hide resolved
depthai_nodes/ml/parsers/utils/ppocr.py Outdated Show resolved Hide resolved
depthai_nodes/ml/parsers/utils/ppocr.py Outdated Show resolved Hide resolved
Co-authored-by: KlemenSkrlj <47853619+klemen1999@users.noreply.github.com>
@aljazkonec1 aljazkonec1 merged commit 9cb663a into dev Sep 10, 2024
@aljazkonec1 aljazkonec1 deleted the paddle-text-detection-parser branch September 12, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsers Changes affecting ml.parsers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants