Closed: Add Map Output Models to Examples and Refactor Visualizers #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbmrz
requested review from
tersekmatija,
kkeroo and
klemen1999
as code owners
klemen1999
approved these changes
Sep 16, 2024
kkeroo
approved these changes
Sep 16, 2024
github-actions
bot
added
enhancement
Test Results143 tests 143 ✅ 1s ⏱️ Results for commit c5d5af9. ♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
jkbmrz
changed the title
jkbmrz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for models with map output (depth, density, heatmap, etc.) to examples. Moreover, it refactors the experiments' visualization code (moving visualizers and their utils to a separate folder, merging mapping.py and visualize.py - cc @kkeroo as the owner of the experiments).
TODO: The code is not yet tested (stalled by the
RuntimeError: Camera(0) - Desired FPS 30 is higher than max FPS of the sensor config: 28.5). EDIT: This is now tested!