-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed: Add Map Output Models to Examples and Refactor Visualizers #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Jakob, the changes make sense and the structure looks better.
Test Results143 tests 143 ✅ 1s ⏱️ Results for commit c5d5af9. ♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This PR adds support for models with map output (depth, density, heatmap, etc.) to examples. Moreover, it refactors the experiments' visualization code (moving visualizers and their utils to a separate folder, merging mapping.py and visualize.py - cc @kkeroo as the owner of the experiments).
TODO: The code is not yet tested (stalled by the
RuntimeError: Camera(0) - Desired FPS 30 is higher than max FPS of the sensor config: 28.5
). EDIT: This is now tested!