Update install_dependencies.sh #828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$VERSION_ID returns the Ubuntu distribution version. We want the base Ubuntu version. Example - Running Linux Mint (Vera): $VERSION_ID returns 21.1 - which is the Mint version number But the distro is based on 22.04, so the script errors out. "inxi -Sx | grep -oP '(?<=Ubuntu\s)\d+\.\d+')" correctly returns 22.04
themarpe
requested changes
May 26, 2023
AnesHadzi
reviewed
Jun 4, 2023
| @@ -112,7 +112,8 @@ elif [ -f /etc/os-release ]; then | |||
| if [[ "$ID" == "ubuntu" || "$ID" == "debian" || "$ID_LIKE" == "ubuntu" || "$ID_LIKE" == "debian" || "$ID_LIKE" == "ubuntu debian" ]]; then | |||
| if [[ ! $(uname -m) =~ ^arm* ]]; then | |||
| sudo apt-get update | |||
| if [[ "$VERSION_ID" > "22.04" || "$VERSION_ID" == "22.04" ]]; then | |||
| UBUNTU_VERSION=$(inxi -Sx | grep -oP '(?<=Ubuntu\s)\d+\.\d+') | |||
There was a problem hiding this comment.
inxi is not a default tool
consider something like
Suggested change
| UBUNTU_VERSION=$(inxi -Sx | grep -oP '(?<=Ubuntu\s)\d+\.\d+') | |
| UBUNTU_VERSION=$(cat /etc/lsb-release | awk -F '=' '/^DISTRIB_RELEASE=/ {{ print $2 }}') |
There was a problem hiding this comment.
Hi @AnesHadzi,
the /etc/lsb-release doesn't return the correct version on Ubuntu Mint (I get 21.1 codename Vera). The correct info can be found in /etc/upstream-release/lsb-release, but I have checked that stock Ubuntu doesn't have that directory. I'm looking for something that would work across all platofrms, but haven't found anything just yet.
Thanks,
Jaka
There was a problem hiding this comment.
I do not have Mint to try, but IIRC ID from etc/os-release should say something like mint, and the system already relies on that param, you can do:
add if [Mint] cat /etc/upstream-release/lsb-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$VERSION_IDreturns the Ubuntu distribution version. We want the base Ubuntu version.Example - Running Linux Mint (Vera):
$VERSION_IDreturns 21.1 - which is the Mint version number, but the distro is based on 22.04, so the script errors out.inxi -Sx | grep -oP '(?<=Ubuntu\s)\d+\.\d+')correctly returns 22.04