[Hotfix] Config version set to 1.0 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klemen1999
requested review from
kozlov721,
tersekmatija and
conorsim
and removed request for
a team
github-actions
bot
added
fix
tersekmatija
approved these changes
Oct 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 92.33% 92.09% -0.25%
==========================================
Files 79 79
Lines 4161 4160 -1
==========================================
- Hits 3842 3831 -11
- Misses 319 329 +10 ☔ View full report in Codecov by Sentry. |
kozlov721
approved these changes
Oct 16, 2024
conorsim
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed config version from
1.1back to1.0.Version was previously bumped to 1.1 because we added optional
nameparameter to thehead. But since this parameter is optional this is not a breaking change and we should leave the version of the config at 1.0 so it doesn't interfere with the schema validation done on HubAI or by DepthAI.I also added a test which checks if the validation goes through if
namefield is specified and if it isn't. The E2E workflow (luxonis-train -> archive -> upload to HubAI -> convert -> run on device) was verified and works as expected.