-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix] Config version set to 1.0 #190
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 92.33% 92.09% -0.25%
==========================================
Files 79 79
Lines 4161 4160 -1
==========================================
- Hits 3842 3831 -11
- Misses 319 329 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changed config version from
1.1
back to1.0
.Version was previously bumped to 1.1 because we added optional
name
parameter to thehead
. But since this parameter is optional this is not a breaking change and we should leave the version of the config at 1.0 so it doesn't interfere with the schema validation done on HubAI or by DepthAI.I also added a test which checks if the validation goes through if
name
field is specified and if it isn't. The E2E workflow (luxonis-train -> archive -> upload to HubAI -> convert -> run on device) was verified and works as expected.