add zturn lite board #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Look at Versa ECP5. |
whitequark
reviewed
Aug 18, 2019
nmigen_boards/zturn_lite.py
Outdated
| package = "clg400" | ||
| speed = "1" | ||
|
|
||
| resources = [] |
There was a problem hiding this comment.
I'm not sure I want to merge this as-is -- no peripherals at all?
There was a problem hiding this comment.
the only external peripherals are connected to the cpu, so they have to be accessed through the ps7 block
whitequark
reviewed
Aug 18, 2019
nmigen_boards/zturn_lite.py
Outdated
| Connector( | ||
| "expansion", 0, | ||
| "- - " | ||
| "B19 E17" |
There was a problem hiding this comment.
This isn't correct. The concatenated string looks like "... B19 E17A20 D18 ..."
whitequark
reviewed
Aug 19, 2019
nmigen_boards/zturn_lite_z007s.py
Outdated
|
|
||
| if __name__ == "__main__": | ||
| from ._blinky import Blinky | ||
| ZTurnLiteZ007SPlatform().build(Blinky(), do_program=True) |
There was a problem hiding this comment.
It doesn't make any sense to run blinky on a board with no LEDs.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a version of this board with the
xc7z007saswell, not sure how to best handle that.