Finalize PR 16 and add Panda wrapper #17
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #16. Compared to previous PR following changes were made:
main
branch on the upstream.In the models provided by this PR there is one difference compared to example-robot-data. Visual meshes were converted from Collada format (
.dae
) to STL format.Also, there is a controversial bit I wanted to raise, as URDF of Panda in example-robot-data includes 9 controllable joints with both finder lips being treated as separate joints. @skleff1994 do you think the finger lips should be locked or kept as they are with an option to disable them with
locked_joints_names
?How I Tested
All examples with Pinocchio, Bullet and MuJoCo were tested, tho they required some changes.
I fulfilled the following requirements