Adding Logs #147
Merged
Adding Logs #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* update: adding ret and err to instrumentation * update: added logs
Mohiiit
requested changes
Oct 10, 2024
Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com>
Mohiiit
reviewed
Oct 11, 2024
Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com>
Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com>
Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com>
Mohiiit
approved these changes
Oct 11, 2024
apoorvsadana
approved these changes
Oct 11, 2024
ocdbytes
pushed a commit
that referenced
this pull request
Oct 16, 2024
* logs to orchestrator * Update/init logs (#148) * update: adding ret and err to instrumentation * update: added logs * update: fixed info logs * update: corrected debugs and trace * fix: removing dummy code * fix: linting * update: fixed issues * Update crates/orchestrator/src/jobs/proving_job/mod.rs Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com> * update: fixed Reviews * update: fixed PR review * Update crates/orchestrator/src/jobs/snos_job/fact_topology.rs Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com> * Update crates/orchestrator/src/jobs/snos_job/mod.rs Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com> * Update crates/orchestrator/src/jobs/snos_job/fact_topology.rs Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com> * update: lint fix --------- Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #137.
Cursorgenerated.