Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFT] Implement Lifecraft Engine #13294

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

jackd149
Copy link
Contributor

@jackd149 jackd149 commented Feb 4, 2025

part of #13033

@github-actions github-actions bot added the cards label Feb 4, 2025
Copy link
Member

@JayDi85 JayDi85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine except miss controlled filter

* @author jackd149
*/
public final class LifecraftEngine extends CardImpl {
private static final FilterCreaturePermanent filter = new FilterCreaturePermanent();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be filter = StaticFilters.FILTER_CONTROLLED_CREATURE or filter = new FilterControlledCreaturePermanent due "Each creature you control of the chosen type"

@JayDi85 JayDi85 merged commit 78fa8e1 into magefree:master Feb 7, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants