Skip to content

Ui Form Reset button issue fixed #40094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: 2.4-develop
Choose a base branch
from
Open

Ui Form Reset button issue fixed #40094

wants to merge 10 commits into from
+7 −7

Conversation

rutvik-monpara
Copy link

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Ui Form Reset button not working as expected #40092

Manual testing scenarios (*)

  1. Open a Customer Add/Edit Form in Admin
  2. Click on Reset button
  3. Without reloading, the form data will get reset

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jul 23, 2025

Hi @rutvik-monpara. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Bravo engcom-Bravo added the Priority: P3 May be fixed according to the position in the backlog. label Jul 23, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jul 23, 2025
@rutvik-monpara
Copy link
Author

@magento run all tests

@rutvik-monpara
Copy link
Author

@magento run all tests

@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Sep 12, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rutvik-monpara,

Thanks for the contribution!

It seems some functional tests are failing due to this change, request you to fix them also fix the failed static test.

Thanks

@engcom-Hotel engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard Sep 16, 2025
@rutvik-monpara
Copy link
Author

Hello @engcom-Hotel,
I don’t understand why the automatic tests are failing. Could you please review the code? There are only two files with a single-line change each, and one of those files is just a test file. So effectively, there’s only one main file with changes, and even there I haven’t made any major modifications, just updated an ID that someone had changed earlier, which actually shouldn’t have been altered. That’s what was causing the issue. Kindly review the code once.

Thanks

@engcom-Charlie engcom-Charlie self-assigned this Sep 18, 2025
@engcom-Charlie
Copy link
Contributor

Hi @rutvik-monpara,

Thank you for your contribution!

Let me have a look into the build failures.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Changes Requested to Review in Progress in Community Dashboard Sep 22, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Sep 23, 2025
@engcom-Bravo engcom-Bravo self-assigned this Sep 24, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Sep 24, 2025
@engcom-Bravo
Copy link
Contributor

Hi @rutvik-monpara,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenarios

  • Open a Customer Add/Edit Form in Admin
  • Click on Reset button
  • Without reloading, the form data will get reset

Before: ✖️

When Clicking on reset the entire page was loading.

After: ✔️

When Clicking on reset without loading entire page the form will reset.

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Sep 24, 2025
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE, Integration Tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@rutvik-monpara
Copy link
Author

@magento run Functional Tests B2B, Functional Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@rutvik-monpara
Copy link
Author

Hello @engcom-Charlie,
I think there’s an issue with the testing/checking process. As you know, sometimes the build fails and then passes on the next run. This really needs improvement because so much time is wasted even for a small change. Can’t we skip this and directly do a code review and merge? Otherwise, it’s wasting your time as well, especially when the build failures aren’t even related to our code. For example, in my case, I only changed one file and the other was just a test file. So why are we spending so much time on this instead of directly reviewing and merging the code? I hope you understand my point and will take the necessary action.

Thanks

@engcom-Charlie
Copy link
Contributor

Hello @engcom-Charlie, I think there’s an issue with the testing/checking process. As you know, sometimes the build fails and then passes on the next run. This really needs improvement because so much time is wasted even for a small change. Can’t we skip this and directly do a code review and merge? Otherwise, it’s wasting your time as well, especially when the build failures aren’t even related to our code. For example, in my case, I only changed one file and the other was just a test file. So why are we spending so much time on this instead of directly reviewing and merging the code? I hope you understand my point and will take the necessary action.

Thanks

@rutvik-monpara, we are proceeding on your PR as per the process.

As you can see this PR was in Changes Requested because there were some static and functional test failure as mentioned here.

I have fixed them and asked for review again. Post that, your PR got reviewed and approved. It also has been tested from our end and its QA Passed as you can see in comments.

As per the process, we are now looking into build stability, once thats done, your PR will move further in Merge in Progress. Then as per the priority it will get merged into 2.4-develop.

Overall, we are going as per our process and in that, review, QA and test fixes has been already taken, soon it will move further to completion.

@rutvik-monpara
Copy link
Author

@magento run Functional Tests B2B, Functional Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@engcom-Charlie
Copy link
Contributor

In last 2 builds, allure is not generated hence running the failed build one more time.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Bravo engcom-Bravo

@engcom-Charlie engcom-Charlie

Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: testing in progress Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Extended testing (optional)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ui Form Reset button not working as expected
4 participants
@rutvik-monpara @engcom-Hotel @engcom-Charlie @engcom-Bravo