Skip to content

Ui Form Reset button issue fixed #40094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: 2.4-develop
Choose a base branch
from
Open

Ui Form Reset button issue fixed #40094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9de730b
Ui Form Reset button issue fixed
rutvik-monpara Jul 23, 2025
713e8ba
Merge branch 'magento:2.4-develop' into fix-for-issue-40092
rutvik-monpara Aug 14, 2025
ee7bbc0
Merge branch '2.4-develop' into fix-for-issue-40092
engcom-Hotel Sep 16, 2025
8d1859c
Merge branch '2.4-develop' into fix-for-issue-40092
rutvik-monpara Sep 17, 2025
1d83cc9
Merge branch '2.4-develop' into fix-for-issue-40092
engcom-Charlie Sep 18, 2025
446a820
Updated the copyright
engcom-Charlie Sep 18, 2025
a8178d5
Merge branch '2.4-develop' into fix-for-issue-40092
engcom-Charlie Sep 22, 2025
f31c59c
Fixed functional test failure
engcom-Charlie Sep 22, 2025
957ddd7
Merge branch '2.4-develop' into fix-for-issue-40092
engcom-Charlie Sep 25, 2025
605a800
Merge branch '2.4-develop' into fix-for-issue-40092
engcom-Charlie Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Search/Test/Mftf/Test/AdminNewSearchSynonymsFormResetTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

<grabValueFrom selector="{{AdminSearchSynonymsNewSection.merge}}" stepKey="grabMergeValue"/>
<assertEquals stepKey="assertMergeDefaultValue">
<expectedResult type="string">0</expectedResult>
<expectedResult type="string">false</expectedResult>
<actualResult type="string">$grabMergeValue</actualResult>
</assertEquals>
</test>
Expand Down
6 changes: 3 additions & 3 deletions app/code/Magento/Ui/view/base/web/js/form/adapter/buttons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2018 Adobe
* All Rights Reserved.
*/

/**
Expand All @@ -10,7 +10,7 @@ define(function () {
'use strict';

return {
'reset': '#reset_ui_form',
'reset': '#reset',
'save': '#save',
'saveAndContinue': '#save_and_continue'
};
Expand Down
6 changes: 3 additions & 3 deletions dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/adapter/buttons.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2024 Adobe
* All Rights Reserved.
*/

/*eslint max-nested-callbacks: 0*/
Expand All @@ -16,7 +16,7 @@ define(['Magento_Ui/js/form/adapter/buttons'], function (uiFormSelectors) {
expect(uiFormSelectors.saveAndContinue).toBeDefined();

// Verify that each selector matches the expected value
expect(uiFormSelectors.reset).toBe('#reset_ui_form');
expect(uiFormSelectors.reset).toBe('#reset');
expect(uiFormSelectors.save).toBe('#save');
expect(uiFormSelectors.saveAndContinue).toBe('#save_and_continue');
});
Expand Down