fix: show confirm emergency stop dialog only when turned on #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
meteyou
approved these changes
Aug 21, 2023
This was referenced Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the emergency stop diaglog showing up, even when its disabled in the settings.
Right now with the option disabled the dialog showed up but the ermergency stop was already emited to moonraker.
Related Tickets & Documents
https://discord.com/channels/758059413700345988/1143208722676580392
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?