Added the windows equivalent command to the unix storybook script. #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "npm run storybook-windows". The unix version fails on a windows machine. Signed-off-by: Jason Smart <jlsmart@meta.com>
srenatus
reviewed
Jan 1, 2025
| @@ -24,6 +24,7 @@ | |||
| "clean": "tsc --build --clean", | |||
| "prepublishOnly": "npm run build", | |||
| "storybook": "rm -rf ./node_modules/.cache && storybook dev -p 6006", | |||
| "storybook-windows": "del /s /q .\\node_modules\\.cache && storybook dev -p 6006", | |||
There was a problem hiding this comment.
just a bystander comment: rimraf is what often gets used for cross-platform removal of old stuff. You'd use rimraf as CLI commands like in this random example
There was a problem hiding this comment.
@srenatus thanks for the tip! wish you had beat me to the review.
There was a problem hiding this comment.
It was merely a chance find on my end. I hadn't been looking at Malloy in a long while 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eg "npm run storybook-windows". The unix version fails on a windows machine.