Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the windows equivalent command to the unix storybook script. #2069

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Added the windows equivalent command to the unix storybook script. #2069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/malloy-render/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"clean": "tsc --build --clean",
"prepublishOnly": "npm run build",
"storybook": "rm -rf ./node_modules/.cache && storybook dev -p 6006",
"storybook-windows": "del /s /q .\\node_modules\\.cache && storybook dev -p 6006",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a bystander comment: rimraf is what often gets used for cross-platform removal of old stuff. You'd use rimraf as CLI commands like in this random example

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srenatus thanks for the tip! wish you had beat me to the review.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was merely a chance find on my end. I hadn't been looking at Malloy in a long while 😅

"build-storybook": "storybook build",
"build-source": "vite build --outDir 'dist/module' --config vite.config.ts",
"build-webcomponent": "vite build --outDir 'dist/webcomponent' --config vite.config.webcomponent.ts && vite build --outDir 'dist/register' --config vite.config.webcomponent-register.ts",
Expand Down
Loading