Prevent leaking of internal information to unprivileged users #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if `SAVEQUERIES` is defined and true (e.g. you installed + activated http://wordpress.org/plugins/query-monitor/), then Sermon Browser will cause the output of information about all database queries (and file paths) in the HTML source, to all users. (I discovered this by examining my page cache files). As well as the information leakage, this was adding 680KB of size to the HTML source for me. The mere presence of that constant is not sufficient to indicate that the site owner wishes debugging information to be made available to all visitors. The change in this branch restricts its display to logged-in + privileged users who have turned on debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
SAVEQUERIESis defined and true (e.g. you installed + activated http://wordpress.org/plugins/query-monitor/), then Sermon Browser will cause the output of information about all database queries (and file paths) in the HTML source, to all users. (I discovered this by examining my page cache files). As well as the information leakage, this was adding 680KB of size to the HTML source for me.The mere presence of that constant is not sufficient to indicate that the site owner wishes debugging information to be made available to all visitors. The change in this branch restricts its display to logged-in + privileged users who have turned on debugging.