Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent leaking of internal information to unprivileged users #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent leaking of internal information to unprivileged users #1

wants to merge 1 commit into from

Commits on Jul 13, 2019

  1. Prevent leaking of internal information to unprivileged users 

    Currently, if `SAVEQUERIES` is defined and true (e.g. you installed + activated http://wordpress.org/plugins/query-monitor/), then Sermon Browser will cause the output of information about all database queries (and file paths) in the HTML source, to all users. (I discovered this by examining my page cache files). As well as the information leakage, this was adding 680KB of size to the HTML source for me.

The mere presence of that constant is not sufficient to indicate that the site owner wishes debugging information to be made available to all visitors. The change in this branch restricts its display to logged-in + privileged users who have turned on debugging.
    @DavidAnderson684
    DavidAnderson684 authored Jul 13, 2019
    Configuration menu
    Copy the full SHA
    e4e0aac View commit details
    Browse the repository at this point in the history