Solution #2514
Solution #2514
Conversation
default case added :) |
| for (const key in state) { | ||
| delete state[key]; | ||
| } | ||
| break; |
There was a problem hiding this comment.
please add empty line after break so it's easier to read
| for (const action of actions) { | ||
| switch (action.type) { | ||
| case 'addProperties': | ||
| Object.assign(state, action.extraData); |
There was a problem hiding this comment.
this can also be achieved using spread operator which is more common nowadays
There was a problem hiding this comment.
Are you sure? The state object should be mutable, and the spread operator creates a copy of it without mutating it. I also cannot change the values of the state because parameters of a function cannot be reassigned, in my opinion its the best way to do
There was a problem hiding this comment.
That's correct, it's very nice that you provided an argument.
|
@Erchu420 I think you've forgotten to push your changes |
check now |
No description provided.