Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #2514

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Solution #2514

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2500050
Solution
Patryk-Filipiak Jun 23, 2023
e5d8c61
added default case
Patryk-Filipiak Jul 26, 2023
d86cebf
New line after break added
Patryk-Filipiak Jul 26, 2023
d765d41
updated
Patryk-Filipiak Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/transformState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,27 @@
* @param {Object[]} actions
*/
function transformState(state, actions) {
// write code here
for (const action of actions) {
switch (action.type) {
case 'addProperties':
Object.assign(state, action.extraData);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can also be achieved using spread operator which is more common nowadays

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? The state object should be mutable, and the spread operator creates a copy of it without mutating it. I also cannot change the values of the state because parameters of a function cannot be reassigned, in my opinion its the best way to do

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct, it's very nice that you provided an argument.

break;

case 'removeProperties':
for (const key of action.keysToRemove) {
delete state[key];
}
break;

case 'clear':
for (const key in state) {
delete state[key];
}
break;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add empty line after break so it's easier to read

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
}

return state;
}

module.exports = transformState;