Stateful object task #2649
Open
Stateful object task #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2023 19:47
Taras2705
suggested changes
Aug 1, 2023
src/transformState.js
Outdated
| } | ||
| break; | ||
| case 'clear': | ||
| for (const key in state) { |
There was a problem hiding this comment.
good job but there is some mistake
1.[ CODE STYLE]: don't use for in loop for iterating over array
roman-mirzoian
suggested changes
Aug 2, 2023
src/transformState.js
Outdated
| break; | ||
|
|
||
| default: | ||
| break; |
There was a problem hiding this comment.
For this task, you can return some message that something went wrong.
src/transformState.js
Outdated
| case 'addProperties': | ||
| for (const key of Object.keys(action.extraData)) { | ||
| state[key] = action.extraData[key]; | ||
| }; |
There was a problem hiding this comment.
It is a little easier to add extraData using Object.assign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.