Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateful object task #2649

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion src/transformState.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,31 @@
* @param {Object[]} actions
*/
function transformState(state, actions) {
// write code here

for (const action of actions) {
switch (action.type) {
case 'addProperties':
for (const key of Object.keys(action.extraData)) {
state[key] = action.extraData[key];
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a little easier to add extraData using Object.assign.

break;
case 'removeProperties':
for (const key of action.keysToRemove) {
delete state[key];
}
break;
case 'clear':
for (const key in state) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job but there is some mistake
1.[ CODE STYLE]: don't use for in loop for iterating over array

delete state[key];
}
break;

default:
break;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
For this task, you can return some message that something went wrong.

}
}

return state;
}

module.exports = transformState;
Loading