Solution #2668
Open
Solution #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moroz-Dmytro
approved these changes
Aug 3, 2023
Comment on lines
+11
to
+25
| case 'addProperties': | ||
| Object.assign(state, action.extraData); | ||
| break; | ||
| case 'removeProperties': | ||
| for (const key of action.keysToRemove) { | ||
| delete state[key]; | ||
| } | ||
| break; | ||
| case 'clear': | ||
| for (const key in state) { | ||
| delete state[key]; | ||
| } | ||
| break; | ||
| default: | ||
| return 'Unexpected error'; |
There was a problem hiding this comment.
Suggested change
| case 'addProperties': | |
| Object.assign(state, action.extraData); | |
| break; | |
| case 'removeProperties': | |
| for (const key of action.keysToRemove) { | |
| delete state[key]; | |
| } | |
| break; | |
| case 'clear': | |
| for (const key in state) { | |
| delete state[key]; | |
| } | |
| break; | |
| default: | |
| return 'Unexpected error'; | |
| case 'addProperties': | |
| Object.assign(state, action.extraData); | |
| break; | |
| case 'removeProperties': | |
| for (const key of action.keysToRemove) { | |
| delete state[key]; | |
| } | |
| break; | |
| case 'clear': | |
| for (const key in state) { | |
| delete state[key]; | |
| } | |
| break; | |
| default: | |
| return 'Unexpected error'; |
There was a problem hiding this comment.
It's easier to read. But even better would be to use curly braces(read more here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.