Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #2668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #2668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/transformState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,27 @@
*/
function transformState(state, actions) {
// write code here
for (const action of actions) {
switch (action.type) {
case 'addProperties':
Object.assign(state, action.extraData);
break;
case 'removeProperties':
for (const key of action.keysToRemove) {
delete state[key];
}
break;
case 'clear':
for (const key in state) {
delete state[key];
}
break;
default:
return 'Unexpected error';
Comment on lines +11 to +25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case 'addProperties':
Object.assign(state, action.extraData);
break;
case 'removeProperties':
for (const key of action.keysToRemove) {
delete state[key];
}
break;
case 'clear':
for (const key in state) {
delete state[key];
}
break;
default:
return 'Unexpected error';
case 'addProperties':
Object.assign(state, action.extraData);
break;
case 'removeProperties':
for (const key of action.keysToRemove) {
delete state[key];
}
break;
case 'clear':
for (const key in state) {
delete state[key];
}
break;
default:
return 'Unexpected error';

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easier to read. But even better would be to use curly braces(read more here)

}
}

return (state);
}

module.exports = transformState;
Loading