Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #5105

wants to merge 1 commit into from

Conversation

Katy4S
Copy link

@Katy4S Katy4S commented Jan 16, 2025

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the calculateRentalCost function! 🎉 Your code meets all the task requirements and constraints, and the logic for applying discounts is correct. Just make sure that the prioritization of the long-term discount over the short-term discount is indeed what you intended. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +15 to +21
if (days >= LONG_TERM) {
return basePrice - LONG_TERM_DISCOUNT;
}

if (days >= SHORT_TERM) {
return basePrice - SHORT_TERM_DISCOUNT;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for applying discounts is correct, but ensure that the long-term discount is intended to be prioritized over the short-term discount. If a rental period qualifies for both discounts, only the long-term discount should be applied. The current implementation does this correctly, but it's important to verify that this is the intended behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants