Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #5105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/calculateRentalCost.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,23 @@
* @return {number}
*/
function calculateRentalCost(days) {
// write code here
const PRICE_PER_DAY = 40;
const LONG_TERM = 7;
const LONG_TERM_DISCOUNT = 50;
const SHORT_TERM = 3;
const SHORT_TERM_DISCOUNT = 20;

const basePrice = days * PRICE_PER_DAY;

if (days >= LONG_TERM) {
return basePrice - LONG_TERM_DISCOUNT;
}

if (days >= SHORT_TERM) {
return basePrice - SHORT_TERM_DISCOUNT;
}
Comment on lines +15 to +21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for applying discounts is correct, but ensure that the long-term discount is intended to be prioritized over the short-term discount. If a rental period qualifies for both discounts, only the long-term discount should be applied. The current implementation does this correctly, but it's important to verify that this is the intended behavior.


return basePrice;
}

module.exports = calculateRentalCost;
Loading