Solution #2379
Open
Solution #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2023 18:38
choeqq
suggested changes
Jul 27, 2023
src/makeRobot.js
Outdated
Comment on lines
59
to
72
| goForward(value) { | ||
| if (value === undefined) { | ||
| this.coords.y += 1; | ||
|
|
||
| return this; | ||
| } | ||
|
|
||
| if (value < 0) { | ||
| return this; | ||
| } | ||
| this.coords.y += value; | ||
|
|
||
| return this; | ||
| }, |
There was a problem hiding this comment.
it is way simple to do it like that:
Suggested change
| goForward(value) { | |
| if (value === undefined) { | |
| this.coords.y += 1; | |
| return this; | |
| } | |
| if (value < 0) { | |
| return this; | |
| } | |
| this.coords.y += value; | |
| return this; | |
| }, | |
| goForward(value = 1) { | |
| if (value > 0) { | |
| this.coords.y += 1; | |
| } | |
| return this; | |
| }, |
src/makeRobot.js
Outdated
Comment on lines
73
to
86
| goBack(value) { | ||
| if (value === undefined) { | ||
| this.coords.y -= 1; | ||
|
|
||
| return this; | ||
| } | ||
|
|
||
| if (value < 0) { | ||
| return this; | ||
| } | ||
| this.coords.y -= value; | ||
|
|
||
| return this; | ||
| }, |
There was a problem hiding this comment.
it is way simple to do it like that:
Suggested change
| goBack(value) { | |
| if (value === undefined) { | |
| this.coords.y -= 1; | |
| return this; | |
| } | |
| if (value < 0) { | |
| return this; | |
| } | |
| this.coords.y -= value; | |
| return this; | |
| }, | |
| goForward(value = 1) { | |
| if (value > 0) { | |
| this.coords.y -= 1; | |
| } | |
| return this; | |
| }, |
src/makeRobot.js
Outdated
Comment on lines
87
to
100
| goRight(value) { | ||
| if (value === undefined) { | ||
| this.coords.x += 1; | ||
|
|
||
| return this; | ||
| } | ||
|
|
||
| if (value < 0) { | ||
| return this; | ||
| } | ||
| this.coords.x += value; | ||
|
|
||
| return this; | ||
| }, |
There was a problem hiding this comment.
it is way simple to do it like that:
Suggested change
| goRight(value) { | |
| if (value === undefined) { | |
| this.coords.x += 1; | |
| return this; | |
| } | |
| if (value < 0) { | |
| return this; | |
| } | |
| this.coords.x += value; | |
| return this; | |
| }, | |
| goForward(value = 1) { | |
| if (value > 0) { | |
| this.coords.x += 1; | |
| } | |
| return this; | |
| }, |
src/makeRobot.js
Outdated
Comment on lines
101
to
114
| goLeft(value) { | ||
| if (value === undefined) { | ||
| this.coords.x -= 1; | ||
|
|
||
| return this; | ||
| } | ||
|
|
||
| if (value < 0) { | ||
| return this; | ||
| } | ||
| this.coords.x -= value; | ||
|
|
||
| return this; | ||
| }, |
There was a problem hiding this comment.
it is way simple to do it like that:
Suggested change
| goLeft(value) { | |
| if (value === undefined) { | |
| this.coords.x -= 1; | |
| return this; | |
| } | |
| if (value < 0) { | |
| return this; | |
| } | |
| this.coords.x -= value; | |
| return this; | |
| }, | |
| goForward(value = 1) { | |
| if (value > 0) { | |
| this.coords.x -= 1; | |
| } | |
| return this; | |
| }, |
There was a problem hiding this comment.
@choeqq thank you, changes added
JoyCoffeeAddict
approved these changes
Jul 27, 2023
| } | ||
|
|
||
| return this; | ||
| }, |
There was a problem hiding this comment.
You could add an empty space here.
choeqq
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.