Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #2379

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #2379

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83ebe66
solution
Jul 24, 2023
7ede641
add task solution
Jul 24, 2023
2d8de11
add suggested changes
Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 81 additions & 1 deletion src/makeRobot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,87 @@
* @return {Robot}
*/
function makeRobot(name, wheels, version) {
// write code here
const robot = {
name,
version,
wheels,
coords: {
x: 0,
y: 0,
},

get info() {
return `name: ${this.name}, chip version: ${this.version}, `
+ `wheels: ${this.wheels}`;
},

get location() {
return `${this.name}: x=${this.coords.x}, y=${this.coords.y}`;
},

goForward(value) {
if (value === undefined) {
this.coords.y += 1;

return this;
}

if (value < 0) {
return this;
}
this.coords.y += value;

return this;
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is way simple to do it like that:

Suggested change
goForward(value) {
if (value === undefined) {
this.coords.y += 1;
return this;
}
if (value < 0) {
return this;
}
this.coords.y += value;
return this;
},
goForward(value = 1) {
if (value > 0) {
this.coords.y += 1;
}
return this;
},

goBack(value) {
if (value === undefined) {
this.coords.y -= 1;

return this;
}

if (value < 0) {
return this;
}
this.coords.y -= value;

return this;
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is way simple to do it like that:

Suggested change
goBack(value) {
if (value === undefined) {
this.coords.y -= 1;
return this;
}
if (value < 0) {
return this;
}
this.coords.y -= value;
return this;
},
goForward(value = 1) {
if (value > 0) {
this.coords.y -= 1;
}
return this;
},

goRight(value) {
if (value === undefined) {
this.coords.x += 1;

return this;
}

if (value < 0) {
return this;
}
this.coords.x += value;

return this;
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is way simple to do it like that:

Suggested change
goRight(value) {
if (value === undefined) {
this.coords.x += 1;
return this;
}
if (value < 0) {
return this;
}
this.coords.x += value;
return this;
},
goForward(value = 1) {
if (value > 0) {
this.coords.x += 1;
}
return this;
},

goLeft(value) {
if (value === undefined) {
this.coords.x -= 1;

return this;
}

if (value < 0) {
return this;
}
this.coords.x -= value;

return this;
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is way simple to do it like that:

Suggested change
goLeft(value) {
if (value === undefined) {
this.coords.x -= 1;
return this;
}
if (value < 0) {
return this;
}
this.coords.x -= value;
return this;
},
goForward(value = 1) {
if (value > 0) {
this.coords.x -= 1;
}
return this;
},

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@choeqq thank you, changes added

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add an empty space here.

evacuate() {
this.coords.x = 1400;
this.coords.y = 500;
},
};

return robot;
}

module.exports = makeRobot;
Loading