Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #2440

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #2440

wants to merge 2 commits into from

Conversation

Taras2705
Copy link

No description provided.

Copy link

@tiserett tiserett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add gaps between functions

src/makeRobot.js Outdated
@@ -38,7 +38,61 @@
* @return {Robot}
*/
function makeRobot(name, wheels, version) {
// write code here
const ROBOT_STEP = 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add 'default' here

@Taras2705 Taras2705 requested a review from tiserett August 6, 2023 19:22
Copy link

@mr-olesha mr-olesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job bro

Copy link

@roman-mirzoian roman-mirzoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, but don`t forget about good code formating.

x: 0,
y: 0,
},
get info() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
get info() {
get info() {

get location() {
return `${this.name}: x=${this.coords.x}, y=${this.coords.y}`;
},
goForward(step = DEFAULT_ROBOT_STEP) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goForward(step = DEFAULT_ROBOT_STEP) {
goForward(step = DEFAULT_ROBOT_STEP) {


return this;
},
goBack(step = DEFAULT_ROBOT_STEP) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goBack(step = DEFAULT_ROBOT_STEP) {
goBack(step = DEFAULT_ROBOT_STEP) {


return this;
},
goRight(step = DEFAULT_ROBOT_STEP) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goRight(step = DEFAULT_ROBOT_STEP) {
goRight(step = DEFAULT_ROBOT_STEP) {


return this;
},
goLeft(step = DEFAULT_ROBOT_STEP) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goLeft(step = DEFAULT_ROBOT_STEP) {
goLeft(step = DEFAULT_ROBOT_STEP) {


return this;
},
evacuate() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
evacuate() {
evacuate() {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants