Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #2440

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 55 additions & 1 deletion src/makeRobot.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,61 @@
* @return {Robot}
*/
function makeRobot(name, wheels, version) {
// write code here
const DEFAULT_ROBOT_STEP = 1;
const ROBOT_EVACUATE_COORDINATS_X = 1400;
const ROBOT_EVACUATE_COORDINATS_Y = 500;

const robot = {
name,
wheels,
version,
coords: {
x: 0,
y: 0,
},
get info() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
get info() {
get info() {

return `name: ${this.name}, chip version: ${this.version},`
+ ` wheels: ${this.wheels}`;
},

get location() {
return `${this.name}: x=${this.coords.x}, y=${this.coords.y}`;
},
goForward(step = DEFAULT_ROBOT_STEP) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goForward(step = DEFAULT_ROBOT_STEP) {
goForward(step = DEFAULT_ROBOT_STEP) {

if (step > 0) {
this.coords.y += step;
}

return this;
},
goBack(step = DEFAULT_ROBOT_STEP) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goBack(step = DEFAULT_ROBOT_STEP) {
goBack(step = DEFAULT_ROBOT_STEP) {

if (step > 0) {
this.coords.y -= step;
}

return this;
},
goRight(step = DEFAULT_ROBOT_STEP) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goRight(step = DEFAULT_ROBOT_STEP) {
goRight(step = DEFAULT_ROBOT_STEP) {

if (step > 0) {
this.coords.x += step;
}

return this;
},
goLeft(step = DEFAULT_ROBOT_STEP) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goLeft(step = DEFAULT_ROBOT_STEP) {
goLeft(step = DEFAULT_ROBOT_STEP) {

if (step > 0) {
this.coords.x -= step;
}

return this;
},
evacuate() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
evacuate() {
evacuate() {

this.coords.x = ROBOT_EVACUATE_COORDINATS_X;
this.coords.y = ROBOT_EVACUATE_COORDINATS_Y;
},
};

return robot;
}

module.exports = makeRobot;
Loading