add task solution #2457
Open
add task solution #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-mirzoian
suggested changes
Aug 4, 2023
src/makeRobot.js
Outdated
| }, | ||
|
|
||
| get info() { | ||
| return `name: ${name}, chip version: ${version}, wheels: ${wheels}`; |
There was a problem hiding this comment.
It is better to access all fields through this, because now you are returning here the data that came as an argument to the makeRobot function, and if we have a method that changes the name, then we will not get the actual name without using this.
Fix this in all code.
src/makeRobot.js
Outdated
|
|
||
| evacuate() { | ||
| this.coords.x = 1400; | ||
| this.coords.y = 500; |
There was a problem hiding this comment.
It is better to take it out into separate constants so that there is no use of "magic numbers".
tiserett
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.