Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #2457

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm install
- run: npm test
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "*",
"@mate-academy/scripts": "^0.3.1",
"@mate-academy/scripts": "^1.2.8",
"eslint": "^5.16.0",
"eslint-plugin-jest": "^22.4.1",
"eslint-plugin-node": "^8.0.1",
Expand Down
59 changes: 58 additions & 1 deletion src/makeRobot.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,64 @@
* @return {Robot}
*/
function makeRobot(name, wheels, version) {
// write code here
const robot = {
name,
wheels,
version,
coords: {
x: 0,
y: 0,
},

get info() {
return `name: ${name}, chip version: ${version}, wheels: ${wheels}`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to access all fields through this, because now you are returning here the data that came as an argument to the makeRobot function, and if we have a method that changes the name, then we will not get the actual name without using this.
Fix this in all code.

},

get location() {
return `${name}: x=${this.coords.x}, y=${this.coords.y}`;
},

goForward(step = 1) {
if (step > 0) {
this.coords.y += step;
}

return this;
},

goBack(step = 1) {
if (step > 0) {
this.coords.y -= step;
}

return this;
},

goRight(step = 1) {
if (step > 0) {
this.coords.x += step;
}

return this;
},

goLeft(step = 1) {
if (step > 0) {
this.coords.x -= step;
}

return this;
},

evacuate() {
this.coords.x = 1400;
this.coords.y = 500;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to take it out into separate constants so that there is no use of "magic numbers".


return this;
},
};

return robot;
}

module.exports = makeRobot;
Loading