js_task_make_robot #2477
Open
js_task_make_robot #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiserett
suggested changes
Aug 6, 2023
src/makeRobot.js
Outdated
Comment on lines
95
to
96
| this.coords.x = 1400; | ||
| this.coords.y = 500; |
src/makeRobot.js
Outdated
|
|
||
| get info() { | ||
| return ( | ||
| `name: ${name}, chip version: ${version}, wheels: ${wheels}` |
There was a problem hiding this comment.
let's use 'this' here
if you ever want to create a function to change these variables - it's not gonna work properly without 'this'
src/makeRobot.js
Outdated
|
|
||
| get location() { | ||
| return ( | ||
| `${name}: x=${this.coords.x}, y=${this.coords.y}` |
dffUqp
approved these changes
Aug 7, 2023
|
|
||
| get info() { | ||
| return ( | ||
| `name: ${this.name}, chip version: ${this.version}, wheels: ${this.wheels}` |
There was a problem hiding this comment.
You can disable this linter error or fix it😀
Next time please don't push the code with error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.