Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js_task_make_robot #2477

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion src/makeRobot.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,68 @@
* @return {Robot}
*/
function makeRobot(name, wheels, version) {
// write code here
const robot = {
name,
wheels,
version,
coords: {
x: 0,
y: 0,
},

get info() {
return (
`name: ${name}, chip version: ${version}, wheels: ${wheels}`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use 'this' here
if you ever want to create a function to change these variables - it's not gonna work properly without 'this'

);
},

get location() {
return (
`${name}: x=${this.coords.x}, y=${this.coords.y}`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with 'this' here

);
},

goForward(step = 1) {
if (step > 0) {
this.coords.y += step;
}

return this;
},

goBack(step = 1) {
if (step > 0) {
this.coords.y -= step;
}

return this;
},

goRight(step = 1) {
if (step > 0) {
this.coords.x += step;
}

return this;
},

goLeft(step = 1) {
if (step > 0) {
this.coords.x -= step;
}

return this;
},

evacuate() {
this.coords.x = 1400;
this.coords.y = 500;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get rid of magic values


return this;
},
};

return robot;
}

module.exports = makeRobot;
Loading