Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeRobot #2501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

GavriliukArtem
Copy link

No description provided.

Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Left a few comments to make your code more advanced)

},

goForward(distance = 1) {
distance > 0 && (this.coords.y += distance);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use an if statement for better readability. For example, 'if (distance > 0) { this.coords.y += distance; }'.

return this;
},
goLeft(distance = 1) {
distance > 0 && (this.coords.x -= distance);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use an if statement for better readability. For example, 'if (distance > 0) { this.coords.x -= distance; }'.

@@ -38,7 +38,59 @@
* @return {Robot}
*/
function makeRobot(name, wheels, version) {
// write code here
const DEFAULT_CORDINAT_Y = 500;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the constant name 'DEFAULT_CORDINAT_Y'. It should be 'DEFAULT_COORDINATE_Y'.

return this;
},
goBack(distance = 1) {
distance > 0 && (this.coords.y -= distance);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use an if statement for better readability. For example, 'if (distance > 0) { this.coords.y -= distance; }'.

return this;
},
goRight(distance = 1) {
distance > 0 && (this.coords.x += distance);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use an if statement for better readability. For example, 'if (distance > 0) { this.coords.x += distance; }'.

@@ -38,7 +38,59 @@
* @return {Robot}
*/
function makeRobot(name, wheels, version) {
// write code here
const DEFAULT_CORDINAT_Y = 500;
const DEFAULT_CORDINAT_X = 1400;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the constant name 'DEFAULT_CORDINAT_X'. It should be 'DEFAULT_COORDINATE_X'.

Comment on lines +56 to +57
`name: ${this.name}, chip version: ${this.version},`
+ ` wheels: ${this.wheels}`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use template literals for better readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants