-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makeRobot #2501
base: master
Are you sure you want to change the base?
makeRobot #2501
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,59 @@ | |
* @return {Robot} | ||
*/ | ||
function makeRobot(name, wheels, version) { | ||
// write code here | ||
const DEFAULT_CORDINAT_Y = 500; | ||
const DEFAULT_CORDINAT_X = 1400; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo in the constant name 'DEFAULT_CORDINAT_X'. It should be 'DEFAULT_COORDINATE_X'. |
||
|
||
const robot = { | ||
name, | ||
wheels, | ||
version, | ||
|
||
coords: { | ||
x: 0, | ||
y: 0, | ||
}, | ||
|
||
get info() { | ||
return ( | ||
`name: ${this.name}, chip version: ${this.version},` | ||
+ ` wheels: ${this.wheels}` | ||
Comment on lines
+56
to
+57
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pls use template literals for better readability |
||
); | ||
}, | ||
|
||
get location() { | ||
return `${this.name}: x=${this.coords.x}, y=${this.coords.y}`; | ||
}, | ||
|
||
evacuate() { | ||
this.coords.x = DEFAULT_CORDINAT_X; | ||
this.coords.y = DEFAULT_CORDINAT_Y; | ||
}, | ||
|
||
goForward(distance = 1) { | ||
distance > 0 && (this.coords.y += distance); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's recommended to use an if statement for better readability. For example, 'if (distance > 0) { this.coords.y += distance; }'. |
||
|
||
return this; | ||
}, | ||
goBack(distance = 1) { | ||
distance > 0 && (this.coords.y -= distance); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's recommended to use an if statement for better readability. For example, 'if (distance > 0) { this.coords.y -= distance; }'. |
||
|
||
return this; | ||
}, | ||
goRight(distance = 1) { | ||
distance > 0 && (this.coords.x += distance); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's recommended to use an if statement for better readability. For example, 'if (distance > 0) { this.coords.x += distance; }'. |
||
|
||
return this; | ||
}, | ||
goLeft(distance = 1) { | ||
distance > 0 && (this.coords.x -= distance); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's recommended to use an if statement for better readability. For example, 'if (distance > 0) { this.coords.x -= distance; }'. |
||
|
||
return this; | ||
}, | ||
|
||
}; | ||
|
||
return robot; | ||
} | ||
|
||
module.exports = makeRobot; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the constant name 'DEFAULT_CORDINAT_Y'. It should be 'DEFAULT_COORDINATE_Y'.