jv-dependency-injection #1015
jv-dependency-injection #1015
Conversation
There was a problem hiding this comment.
Congratulations on implementing the code according to the specifications! 🌟 Your use of annotations, exception handling, and adherence to dependency injection principles is commendable. Keep up the good work and always aim to handle potential exceptions gracefully to enhance the robustness of your applications. Happy coding! 💻🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| @Retention(RetentionPolicy.RUNTIME) | ||
| public @interface Component { |
There was a problem hiding this comment.
According to the checklist, don't forget to add @Target to custom annotations. It specifies the kinds of program element to which an annotation type is applicable.
| } catch (Exception e) { | ||
| throw new RuntimeException("Failed to create instance of " + implClass.getName(), e); |
There was a problem hiding this comment.
It is better to replace many exceptions that have a common parent with a general parental exception to simplify the catch block. Consider using ReflectiveOperationException which is a common superclass of the exceptions thrown by reflective operations in the java.lang.reflect package.
| public Object getInstance(Class<?> interfaceClazz) { | ||
| return null; | ||
| // Try to resolve implementation for the given interface | ||
| Class<?> implClass = findImplementation(interfaceClazz); | ||
|
|
||
| // Check if class is annotated with @Component | ||
| if (!implClass.isAnnotationPresent(Component.class)) { | ||
| throw new RuntimeException("Class " + implClass.getName() | ||
| + " is not marked as @Component"); | ||
| } | ||
|
|
||
| // Check if an instance already exists | ||
| if (instances.containsKey(implClass)) { | ||
| return instances.get(implClass); | ||
| } | ||
|
|
||
| // Create a new instance and inject dependencies | ||
| Object instance = createInstance(implClass); | ||
| instances.put(implClass, instance); | ||
| return instance; | ||
| } |
There was a problem hiding this comment.
Make Interface Implementations map a class field. You can fill it in using Map.of(). This will help to avoid using the if statements in the findImplementation method for determining the implementation class.
| if (!implClass.isAnnotationPresent(Component.class)) { | ||
| throw new RuntimeException("Class " + implClass.getName() | ||
| + " is not marked as @Component"); |
There was a problem hiding this comment.
When throwing an exception add an informative message to it. Also, don't forget to add an exception you're catching in catch block to the RuntimeException object you throw. This will provide more context in the error message and make debugging easier.
No description provided.