Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jv-dependency-injection #1015

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/mate.academy/Main.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@
public class Main {

public static void main(String[] args) {
// Please test your Injector here. Feel free to push this class as a part of your solution
Injector injector = Injector.getInjector();
ProductService productService = null;
ProductService productService = (ProductService) injector.getInstance(ProductService.class);
List<Product> products = productService.getAllFromFile("products.txt");
products.forEach(System.out::println);
}
Expand Down
5 changes: 4 additions & 1 deletion src/main/java/mate.academy/lib/Component.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package mate.academy.lib;

public @interface Component {
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;

@Retention(RetentionPolicy.RUNTIME)
public @interface Component {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, don't forget to add @Target to custom annotations. It specifies the kinds of program element to which an annotation type is applicable.

}
5 changes: 4 additions & 1 deletion src/main/java/mate.academy/lib/Inject.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package mate.academy.lib;

public @interface Inject {
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;

@Retention(RetentionPolicy.RUNTIME)
public @interface Inject {
}
57 changes: 56 additions & 1 deletion src/main/java/mate.academy/lib/Injector.java
Original file line number Diff line number Diff line change
@@ -1,13 +1,68 @@
package mate.academy.lib;

import java.lang.reflect.Field;
import java.util.HashMap;
import java.util.Map;

public class Injector {
private static final Injector injector = new Injector();
private final Map<Class<?>, Object> instances = new HashMap<>();

public static Injector getInjector() {
return injector;
}

public Object getInstance(Class<?> interfaceClazz) {
return null;
// Try to resolve implementation for the given interface
Class<?> implClass = findImplementation(interfaceClazz);

// Check if class is annotated with @Component
if (!implClass.isAnnotationPresent(Component.class)) {
throw new RuntimeException("Class " + implClass.getName()
+ " is not marked as @Component");
Comment on lines +18 to +20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When throwing an exception add an informative message to it. Also, don't forget to add an exception you're catching in catch block to the RuntimeException object you throw. This will provide more context in the error message and make debugging easier.

}

// Check if an instance already exists
if (instances.containsKey(implClass)) {
return instances.get(implClass);
}

// Create a new instance and inject dependencies
Object instance = createInstance(implClass);
instances.put(implClass, instance);
return instance;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make Interface Implementations map a class field. You can fill it in using Map.of(). This will help to avoid using the if statements in the findImplementation method for determining the implementation class.


private Object createInstance(Class<?> implClass) {
try {
Object instance = implClass.getDeclaredConstructor().newInstance();

// Inject dependencies into fields annotated with @Inject
for (Field field : implClass.getDeclaredFields()) {
if (field.isAnnotationPresent(Inject.class)) {
field.setAccessible(true);
Object fieldInstance = getInstance(field.getType());
field.set(instance, fieldInstance);
}
}

return instance;
} catch (Exception e) {
throw new RuntimeException("Failed to create instance of " + implClass.getName(), e);
Comment on lines +45 to +46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to replace many exceptions that have a common parent with a general parental exception to simplify the catch block. Consider using ReflectiveOperationException which is a common superclass of the exceptions thrown by reflective operations in the java.lang.reflect package.

}
}

private Class<?> findImplementation(Class<?> interfaceClazz) {
if (interfaceClazz.isInterface()) {
if (interfaceClazz == mate.academy.service.FileReaderService.class) {
return mate.academy.service.impl.FileReaderServiceImpl.class;
} else if (interfaceClazz == mate.academy.service.ProductParser.class) {
return mate.academy.service.impl.ProductParserImpl.class;
} else if (interfaceClazz == mate.academy.service.ProductService.class) {
return mate.academy.service.impl.ProductServiceImpl.class;
}
throw new RuntimeException("No implementation found for " + interfaceClazz.getName());
}
return interfaceClazz;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
import java.io.IOException;
import java.nio.file.Files;
import java.util.List;
import mate.academy.lib.Component;
import mate.academy.service.FileReaderService;

@Component
public class FileReaderServiceImpl implements FileReaderService {
@Override
public List<String> readFile(String fileName) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package mate.academy.service.impl;

import java.math.BigDecimal;
import mate.academy.lib.Component;
import mate.academy.model.Product;
import mate.academy.service.ProductParser;

@Component
public class ProductParserImpl implements ProductParser {
public static final int ID_POSITION = 0;
public static final int NAME_POSITION = 1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,18 @@

import java.util.List;
import java.util.stream.Collectors;
import mate.academy.lib.Component;
import mate.academy.lib.Inject;
import mate.academy.model.Product;
import mate.academy.service.FileReaderService;
import mate.academy.service.ProductParser;
import mate.academy.service.ProductService;

@Component
public class ProductServiceImpl implements ProductService {
@Inject
private ProductParser productParser;
@Inject
private FileReaderService fileReaderService;

@Override
Expand Down
Loading