Develop #2155

MrGizmen · 2024-09-22T12:17:25Z

No description provided.

mateacademy-ai-mentor

It looks like you've put in a lot of effort here, and you're almost there! 👍 However, there are a few key areas we need to address to make sure the functionality is spot on. The messages in the startWork and stopWork methods across different machine types need to be more informative. Also, using polymorphism with the Machine class can make your code cleaner and more flexible. Let's make these adjustments to get your code in tip-top shape! 🛠️ Remember, these changes are important for maintaining clear communication in your program's output and for future-proofing your code against changes. Keep up the great work, and I'm confident you'll have this polished in no time! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/main/java/core/basesyntax/Bulldozer.java

src/main/java/core/basesyntax/Excavator.java

src/main/java/core/basesyntax/Machine.java

src/main/java/core/basesyntax/MainApp.java

src/main/java/core/basesyntax/Truck.java

MrGizmen · 2024-09-22T15:24:47Z

.

mateacademy-ai-mentor

Great job on implementing the Machine class and adhering to the checklist! Remember that informative messages can greatly improve the readability and maintainability of your code, so keep that in mind for future projects. Keep up the good work! 😊👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-09-22T15:40:47Z

src/main/java/core/basesyntax/Bulldozer.java

+
+    @Override
+    public void doWork() {
+        System.out.println("Bulldozer" + " " + machineType + " " + "started its work.");


The message in the doWork method should be more informative and indicate that the Bulldozer is working. Consider including the specific action it performs, for example, 'Bulldozer is moving earth'.

mateacademy-ai-mentor · 2024-09-22T15:40:47Z

src/main/java/core/basesyntax/Bulldozer.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Bulldozer" + " " + machineType + " " + "stopped working.");


Similarly, the message in the stopWork method should be more informative. Rather than just saying 'stopped working', it could be more descriptive, like 'Bulldozer has finished moving earth'.

mateacademy-ai-mentor · 2024-09-22T15:40:47Z

src/main/java/core/basesyntax/Excavator.java

+
+    @Override
+    public void doWork() {
+        System.out.println("Exavator" + " " + machineType + " " + "started its work.");


There's a typo in the message printed to the console. It should be 'Excavator' instead of 'Exavator'. Make sure the messages are informative and correctly spelled.

mateacademy-ai-mentor · 2024-09-22T15:40:47Z

src/main/java/core/basesyntax/Excavator.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Exavator" + " " + machineType + " " + "stopped working.");


The same typo is present in the 'stopWork' method. It should be corrected to 'Excavator'.

mateacademy-ai-mentor · 2024-09-22T15:40:48Z

src/main/java/core/basesyntax/MainApp.java

+
+        Machine[] machines = {truck, bulldozer, excavator};
+        printTotal(machines);
+        System.out.println();


There's a redundant empty line after the call to printTotal(machines) method. According to the checklist, we should avoid adding unnecessary empty lines after method calls.

mateacademy-ai-mentor · 2024-09-22T15:40:48Z

src/main/java/core/basesyntax/MainApp.java

+            machine.doWork();
+            machine.stopWork();
+        }
+        System.out.println(Arrays.toString(machines));


The System.out.println(Arrays.toString(machines)); does not provide an informative message about the machines. It's better to have messages that indicate what type of machine is working. Consider overriding the toString method in each Machine subclass to provide more informative output.

mateacademy-ai-mentor · 2024-09-22T15:40:48Z

src/main/java/core/basesyntax/Truck.java

+
+    @Override
+    public void doWork() {
+        System.out.println("Truck" + " " + machineType + " " + "started its work.");


The message should be more informative and in proper English. Instead of concatenating strings with spaces, you can use a formatted string. For example: System.out.println("Truck " + machineType + " started its work.");

mateacademy-ai-mentor · 2024-09-22T15:40:48Z

src/main/java/core/basesyntax/Truck.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Truck" + " " + machineType + " " + "stopped working. ");


The stop message should also be informative and properly formatted. Consider changing it to: System.out.println("Truck " + machineType + " stopped working.");

mateacademy-ai-mentor · 2024-09-22T15:40:48Z

src/main/java/core/basesyntax/Truck.java

+
+    @Override
+    public String toString() {
+        return machineType;


The toString method should return a string that represents the object. Returning only machineType is not very informative. Consider including the class name and other relevant information.

slade13

Please remove machineType variable. Besides that everything seems to be correct, please check my comments.

slade13 · 2024-09-23T06:59:32Z

src/main/java/core/basesyntax/Machine.java

+package core.basesyntax;
+
+public abstract class Machine {
+    protected String machineType;


The 'machineType' variable seems unnecessary in this context as the type of machine can be determined by the instance of the class. Consider removing this and the associated constructor and toString method if not needed for other parts of your program.

slade13 · 2024-09-23T06:59:32Z

src/main/java/core/basesyntax/MainApp.java

 public class MainApp {
+    public static void main(String[] args) {
+
+        Machine truck = new Truck("Mikki");


The constructors for Truck, Bulldozer, and Excavator classes are not defined in the task. If these classes have constructors that take parameters, mention it in the task definition. If not, use default constructors instead.

slade13 · 2024-09-23T06:59:33Z

src/main/java/core/basesyntax/MainApp.java

+            machine.doWork();
+            machine.stopWork();
+        }
+        System.out.println(Arrays.toString(machines));


This line is unnecessary. The printTotal method is supposed to invoke doWork() and stopWork() on each machine, there is no need to print an array of Machines.

So, should only output this?

Truck Mikki started its work.
Truck Mikki stopped working.
Bulldozer Eduardo started its work.
Bulldozer Eduardo stopped working.
Excavator Maks started its work.
Excavator Maks stopped working.

slade13 · 2024-09-23T06:59:37Z

src/main/java/core/basesyntax/Excavator.java

+
+public class Excavator extends Machine {
+
+    public Excavator(String machineType) {


The constructor for the Excavator class is unnecessary as it just calls the superclass constructor. Consider removing it if there's no additional logic inside.

slade13 · 2024-09-23T06:59:37Z

src/main/java/core/basesyntax/Excavator.java

+
+    @Override
+    public String toString() {
+        return machineType;


It's not clear what the purpose of the overridden toString() method is, as it only returns 'machineType'. If it's not necessary, consider removing it to use the inherited method from Object class.

slade13 · 2024-09-23T06:59:41Z

src/main/java/core/basesyntax/Truck.java

+
+public class Truck extends Machine {
+
+    public Truck(String machineType) {


The Machine class was not described as having a constructor that takes a machineType parameter. It's better to remove the constructor from the Truck class.

slade13 · 2024-09-23T06:59:44Z

src/main/java/core/basesyntax/Bulldozer.java

+    }
+
+    @Override
+    public String toString() {


The 'machineType' field is not defined in this class. If 'machineType' is a field in the parent class, it should be accessed using 'super.machineType'. Or better yet, since this class already represents a specific machine type (Bulldozer), 'machineType' is not needed in the toString() method. You can return "Bulldozer" instead.

slade13 · 2024-09-23T06:59:44Z

src/main/java/core/basesyntax/Bulldozer.java

+
+public class Bulldozer extends Machine {
+
+    public Bulldozer(String machineType) {


The constructor is taking a parameter 'machineType' that seems unnecessary. The type of machine is already known (Bulldozer) and does not need to be passed as a parameter.

slade13 · 2024-09-23T06:59:44Z

src/main/java/core/basesyntax/Bulldozer.java

+
+    @Override
+    public void doWork() {
+        System.out.println("Bulldozer" + " " + machineType + " " + "started its work.");


The 'machineType' field is not defined in this class. If 'machineType' is a field in the parent class, it should be accessed using 'super.machineType'. Or better yet, since this class already represents a specific machine type (Bulldozer), 'machineType' is not needed. Simply print "Bulldozer started its work."

slade13 · 2024-09-23T06:59:44Z

src/main/java/core/basesyntax/Bulldozer.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Bulldozer" + " " + machineType + " " + "stopped working.");


The 'machineType' field is not defined in this class. If 'machineType' is a field in the parent class, it should be accessed using 'super.machineType'. Or better yet, since this class already represents a specific machine type (Bulldozer), 'machineType' is not needed. Simply print "Bulldozer stopped working."

MateuszRostek

Please read again comments provided by mentor in previous review.

MateuszRostek · 2024-09-23T15:40:06Z

src/main/java/core/basesyntax/Machine.java

@@ -0,0 +1,13 @@
+package core.basesyntax;
+
+public abstract class Machine {


This is how this class should look like:

public abstract class Machine { public abstract void doWork(); public abstract void stopWork(); }

MateuszRostek · 2024-09-23T15:40:37Z

src/main/java/core/basesyntax/Excavator.java

+
+public class Excavator extends Machine {
+
+    public Excavator(String machine) {


All constructors & toString methods should be removed.

MateuszRostek · 2024-09-23T15:41:16Z

src/main/java/core/basesyntax/Excavator.java

+    @Override
+    public void doWork() {
+        System.out.println("Excavator" + " " + machine + " " + "started its work.");
+    }
+
+    @Override
+    public void stopWork() {
+        System.out.println("Excavator" + " " + machine + " " + "stopped working.");
+
+    }


Please read previous comments about these methods.

George-Khomiak · 2024-10-03T10:48:24Z

src/main/java/core/basesyntax/MainApp.java

+    public static void main(String[] args) {
+        Machine truck = new Truck("Katarzyna");
+        Machine bulldozer = new Bulldozer("Eduardo");
+        Machine excavator = new Excavator("Maks");


As Mateusz mentioned in the previous comment, you should remove all constructors from Machine child classes. If Java class doesn't have any explicitly defined constructor it will use the default one, so in this case you will be able to create Truck/Bulldozer/Excavator instances like this: Machine truck = new Truck(); Notice that in this case you don't have to provide "name" of the machine, because you are able to use default constructor, i.e. new Truck(); That's why you should remove "name" fields in all child classes and delete a constructors you created.

George-Khomiak · 2024-10-03T10:50:04Z

src/main/java/core/basesyntax/Excavator.java

+public class Excavator extends Machine {
+    private String name;
+
+    public Excavator(String name) {


Remove constructor and "name" field to be able to create instances without providing a name

George-Khomiak · 2024-10-03T10:50:12Z

src/main/java/core/basesyntax/Bulldozer.java

+public class Bulldozer extends Machine {
+    private String name;
+
+    public Bulldozer(String name) {


Remove constructor and "name" field to be able to create instances without providing a name

George-Khomiak · 2024-10-03T10:50:27Z

src/main/java/core/basesyntax/Truck.java

+
+    public Truck(String name) {
+        this.name = name;
+    }


Remove constructor and "name" field to be able to create instances without providing a name

George-Khomiak

Well done, just to clarify one thing - the constructor you are creating i.e.
public Bulldozer() { } is actually redundant, because Java Classes have something called "default constructor" and if you didn't create any constructor it will have default one, even though you don't see it. And it looks exactly the same as yours
public Bulldozer() { }

So basically you created a default constructor, which is already there.
Anyways, good job :)

MrGizmen added 5 commits September 19, 2024 16:24

Initial commit

41ff595

Initial commit

f07c826

Initial commit

7d37697

Initial commit

6de7435

clean code

3228d53

mateacademy-ai-mentor suggested changes Sep 22, 2024

View reviewed changes

MrGizmen added 6 commits September 22, 2024 15:12

changing errors (polimorfizm and abstraction)

7763d6b

changing errors (polimorfizm and abstraction)

80670e8

changing errors(polimorfizm and abstraction)

04cb25a

deleted space

22b9998

deleted clean spaced

9c0365f

added new lasted line

fcc3152

MrGizmen requested a review from mateacademy-ai-mentor September 22, 2024 15:40

mateacademy-ai-mentor approved these changes Sep 22, 2024

View reviewed changes

slade13 suggested changes Sep 23, 2024

View reviewed changes

MrGizmen added 2 commits September 23, 2024 12:39

Correction and improvement code

e6b6360

Merge branch 'develop' of github.com:MrGizmen/jv-oop into develop

f9e1a4f

MrGizmen requested a review from slade13 September 23, 2024 10:54

MateuszRostek suggested changes Sep 23, 2024

View reviewed changes

MrGizmen requested a review from mateacademy-ai-mentor October 3, 2024 09:25

small changes number two

6c223ab

MrGizmen requested a review from MateuszRostek October 3, 2024 09:50

MrGizmen added 4 commits October 3, 2024 11:56

small changes number two

e19fc19

small changes number two

5a3b993

small changes number two

93626c1

small changes number two

a7f2105

George-Khomiak suggested changes Oct 3, 2024

View reviewed changes

small changes number two

c945605

MrGizmen requested a review from George-Khomiak October 3, 2024 11:06

George-Khomiak approved these changes Oct 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop #2155

Develop #2155

MrGizmen commented Sep 22, 2024

mateacademy-ai-mentor left a comment

MrGizmen commented Sep 22, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Sep 22, 2024

mateacademy-ai-mentor Sep 22, 2024

mateacademy-ai-mentor Sep 22, 2024

mateacademy-ai-mentor Sep 22, 2024

mateacademy-ai-mentor Sep 22, 2024

mateacademy-ai-mentor Sep 22, 2024

mateacademy-ai-mentor Sep 22, 2024

mateacademy-ai-mentor Sep 22, 2024

mateacademy-ai-mentor Sep 22, 2024

slade13 left a comment

slade13 Sep 23, 2024

slade13 Sep 23, 2024

slade13 Sep 23, 2024

MrGizmen Sep 23, 2024

slade13 Sep 23, 2024

slade13 Sep 23, 2024

slade13 Sep 23, 2024

slade13 Sep 23, 2024

slade13 Sep 23, 2024

slade13 Sep 23, 2024

slade13 Sep 23, 2024

MateuszRostek left a comment

MateuszRostek Sep 23, 2024

MateuszRostek Sep 23, 2024

MateuszRostek Sep 23, 2024

George-Khomiak Oct 3, 2024

George-Khomiak Oct 3, 2024

George-Khomiak Oct 3, 2024

George-Khomiak Oct 3, 2024

George-Khomiak left a comment


		public class Excavator extends Machine {

		public Excavator(String machineType) {


		public class Truck extends Machine {

		public Truck(String machineType) {


		public class Bulldozer extends Machine {

		public Bulldozer(String machineType) {

		@@ -0,0 +1,13 @@
		package core.basesyntax;

		public abstract class Machine {


		public class Excavator extends Machine {

		public Excavator(String machine) {

Develop #2155

Are you sure you want to change the base?

Develop #2155

Conversation

MrGizmen commented Sep 22, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

MrGizmen commented Sep 22, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slade13 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MateuszRostek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

George-Khomiak left a comment

Choose a reason for hiding this comment