Develop #2155
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package core.basesyntax; | ||
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
||
| public Bulldozer(String machine) { | ||
| super(machine); | ||
| } | ||
|
|
||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Bulldozer" + " " + machine + " " + "is moving earth."); | ||
| } | ||
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Bulldozer" + " " + machine + " " + "has finished moving earth."); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "Bulldozer"; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package core.basesyntax; | ||
|
|
||
| public class Excavator extends Machine { | ||
|
|
||
| public Excavator(String machine) { | ||
|
There was a problem hiding this comment. All constructors & |
||
| super(machine); | ||
| } | ||
MrGizmen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Excavator" + " " + machine + " " + "started its work."); | ||
| } | ||
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Excavator" + " " + machine + " " + "stopped working."); | ||
|
|
||
| } | ||
|
There was a problem hiding this comment. Please read previous comments about these methods. |
||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "Excavator"; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package core.basesyntax; | ||
|
|
||
| public abstract class Machine { | ||
|
There was a problem hiding this comment. This is how this class should look like: public abstract class Machine {
public abstract void doWork();
public abstract void stopWork();
} |
||
| protected String machine; | ||
|
There was a problem hiding this comment. The field 'machine' is somewhat ambiguous. Consider renaming it to something more descriptive that reflects its purpose in the context of a 'Machine', such as 'machineType' or 'machineName'. |
||
|
|
||
| public Machine(String machine) { | ||
| this.machine = machine; | ||
| } | ||
|
There was a problem hiding this comment. The constructor parameter 'machine' should be renamed for clarity. If this is intended to represent the type or name of the machine, consider renaming the parameter to 'machineType' or 'machineName' to match the suggested field name change. |
||
|
|
||
| public abstract void doWork(); | ||
|
|
||
| public abstract void stopWork(); | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,23 @@ | ||
| package core.basesyntax; | ||
|
|
||
| import java.util.Arrays; | ||
|
|
||
| public class MainApp { | ||
| public static void main(String[] args) { | ||
|
|
||
| Machine truck = new Truck("Mikki"); | ||
|
There was a problem hiding this comment. The constructors for Truck, Bulldozer, and Excavator classes are not defined in the task. If these classes have constructors that take parameters, mention it in the task definition. If not, use default constructors instead. |
||
| Machine bulldozer = new Bulldozer("Eduardo"); | ||
| Machine excavator = new Excavator("Maks"); | ||
|
There was a problem hiding this comment. As Mateusz mentioned in the previous comment, you should remove all constructors from Machine child classes. If Java class doesn't have any explicitly defined constructor it will use the default one, so in this case you will be able to create Truck/Bulldozer/Excavator instances like this: Machine truck = new Truck(); Notice that in this case you don't have to provide "name" of the machine, because you are able to use default constructor, i.e. new Truck(); That's why you should remove "name" fields in all child classes and delete a constructors you created. |
||
|
|
||
| Machine[] machines = {truck, bulldozer, excavator}; | ||
| printTotal(machines); | ||
| } | ||
|
|
||
| private static void printTotal(Machine[] machines) { | ||
| for (Machine machine : machines) { | ||
| machine.doWork(); | ||
| machine.stopWork(); | ||
| } | ||
| System.out.println(Arrays.toString(machines)); | ||
MrGizmen marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. The There was a problem hiding this comment. This line is unnecessary. The printTotal method is supposed to invoke doWork() and stopWork() on each machine, there is no need to print an array of Machines. There was a problem hiding this comment. So, should only output this? Truck Mikki started its work. |
||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package core.basesyntax; | ||
|
|
||
| public class Truck extends Machine { | ||
|
|
||
| public Truck(String machine) { | ||
| super(machine); | ||
| } | ||
|
There was a problem hiding this comment. Remove constructor and "name" field to be able to create instances without providing a name |
||
|
|
||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Truck" + " " + machine + " " + "started its work."); | ||
| } | ||
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck" + " " + machine + " " + "stopped working. "); | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "Truck"; | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'machineType' field is not defined in this class. If 'machineType' is a field in the parent class, it should be accessed using 'super.machineType'. Or better yet, since this class already represents a specific machine type (Bulldozer), 'machineType' is not needed in the toString() method. You can return "Bulldozer" instead.