Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #608

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #608

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
497662d
Solution
oksanaklw Oct 11, 2024
127dc05
solution after comments
oksanaklw Oct 11, 2024
ca54c2f
solution after comments
oksanaklw Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 48 additions & 6 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,66 @@


class IntegerRange:
pass
def __init__(
self,
min_amount: int,
max_amount: int
) -> None:
self.min_amount = min_amount
self.max_amount = max_amount

def __set_name__(self, instance: "Visitor", name: str) -> None:
self.protected_name = "_" + name

def __get__(self, instance: "Visitor", owner: object) -> object:
return getattr(instance, self.protected_name)

def __set__(self, instance: "Visitor", value: int) -> None:
if not isinstance(value, int):
raise TypeError()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to provide an error message when raising exceptions. This helps to understand what exactly went wrong. For example, you can modify this line to raise TypeError('Expected an integer value').

if not (self.min_amount <= value <= self.max_amount):
raise ValueError()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, it's better to provide an error message when raising exceptions. Modify this line to raise ValueError('Value out of the allowed range').

setattr(instance, self.protected_name, value)


class Visitor:
pass

def __init__(self, name: str, age: int, weight: int, height: int) -> None:
self.name = name
self.age = age
self.weight = weight
self.height = height
Comment on lines 27 to +33
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Visitor class is a simple data class that holds information about a visitor. It might be a good idea to add some data validation in the __init__ method to ensure that the name is a string and that age, weight, and height are integers.



class SlideLimitationValidator(ABC):
pass
def __init__(self, age: int, weight: int, height: int) -> None:
self.age = age
self.weight = weight
self.height = height
Comment on lines 36 to +40
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SlideLimitationValidator class is an abstract base class that defines the interface for all slide limitation validators. This is a good use of the ABC module to define a common interface.



class ChildrenSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(4, 14)
weight = IntegerRange(20, 50)
height = IntegerRange(80, 120)


class AdultSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(14, 60)
weight = IntegerRange(50, 120)
height = IntegerRange(120, 220)
Comment on lines 43 to +52
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChildrenSlideLimitationValidator and AdultSlideLimitationValidator classes inherit from SlideLimitationValidator and define specific age, weight, and height limitations for children and adults. This is a good use of inheritance to create specific behavior based on the type of visitor.



class Slide:
pass
def __init__(self, name: str,
limitation_class: SlideLimitationValidator) -> None:
self.name = name
self.limitation_class = limitation_class

def can_access(self, visitor: Visitor) -> bool:
try:
self.limitation_class(visitor.age, visitor.weight, visitor.height)
except ValueError or TypeError:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you catch multiple exceptions, they should be put into a tuple, not separated by or. Correct this line to except (ValueError, TypeError):.

return False
else:
return True
Loading