Solution #1333
Solution #1333
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this task! Your implementation is almost there, but there's a critical issue that needs to be addressed before we can approve the pull request. The hidden attribute should be an instance variable rather than a class variable to ensure each animal has its own hidden state. This change is essential for the correct functionality of your code. Once you make this adjustment, your solution will be much stronger. Keep up the great work, and I'm confident you'll nail it! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
app/main.py
Outdated
| @@ -1 +1,32 @@ | |||
| # write your code here | |||
| class Animal: | |||
| hidden = False | |||
There was a problem hiding this comment.
The hidden attribute is defined as a class variable, but it should be an instance variable. Each animal instance should have its own hidden state, so it should be defined within the __init__ method.
| # write your code here | ||
| class Animal: | ||
| hidden = False | ||
| alive = [] |
There was a problem hiding this comment.
The alive list is defined as a class variable, which is correct for tracking all instances. However, ensure that objects are properly removed from this list when they are no longer alive to prevent memory leaks or incorrect length calculations.
|
|
||
| class Herbivore(Animal): | ||
| def hide(self) -> None: | ||
| self.hidden = not self.hidden |
There was a problem hiding this comment.
The hidden attribute should be an instance variable, but it is currently a class variable. You should initialize self.hidden in the __init__ method of the Animal class.
| class Carnivore(Animal): | ||
| @classmethod | ||
| def bite(cls, goal: Animal) -> None: | ||
| if isinstance(goal, Herbivore) and not goal.hidden: | ||
| goal.health -= 50 | ||
| goal.remove_if_dead() |
There was a problem hiding this comment.
Why you need two Carnivore classes?
please remove one of them
|
|
||
|
|
||
| class Carnivore(Animal): | ||
| @classmethod |
There was a problem hiding this comment.
There is no need to make this method as a classmethod since cls is not called. You could make it static in the current implementation
|
|
||
| class Carnivore(Animal): | ||
| @classmethod | ||
| def bite(cls, goal: Animal) -> None: |
There was a problem hiding this comment.
It is better to explicitly indicate that goal should be Herbivore class instance
| def __len__(self) -> int: | ||
| return len(Animal.alive) |
There was a problem hiding this comment.
There is no need for __len__ here, remove it
No description provided.