Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1333

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 49 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,49 @@
# write your code here
class Animal:
alive = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alive list is defined as a class variable, which is correct for tracking all instances. However, ensure that objects are properly removed from this list when they are no longer alive to prevent memory leaks or incorrect length calculations.

def __init__(self, name: str, health: int = 100) -> None:
self.name = name
self.health = health
self.hidden = False # Set hidden as an instance variable
Animal.alive.append(self)

def __len__(self) -> int:
return len(Animal.alive)

Comment on lines +10 to +11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for __len__ here, remove it

def __repr__(self) -> str:
return (
f"{{Name: {self.name}, "
f"Health: {self.health}, "
f"Hidden: {self.hidden}}}"
)

def remove_if_dead(self) -> None:
if self.health <= 0:
Animal.alive.remove(self)


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):
@classmethod
def bite(cls, goal: Animal) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to make this method as a classmethod since cls is not called. You could make it static in the current implementation

if isinstance(goal, Herbivore) and not goal.hidden:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to explicitly indicate that goal should be Herbivore class instance

goal.health -= 50
goal.remove_if_dead()

Comment on lines +30 to +35
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you need two Carnivore classes?
please remove one of them


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hidden attribute should be an instance variable, but it is currently a class variable. You should initialize self.hidden in the __init__ method of the Animal class.


class Carnivore(Animal):
@classmethod
def bite(cls, goal: Animal) -> None:
if isinstance(goal, Herbivore) and not goal.hidden:
goal.health -= 50
if goal.health <= 0:
Animal.alive.remove(goal)
Loading